waf: move chibios hwdef generation to explicit call #27991
+37
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshanne
commented
Sep 3, 2024
|
I do like this. This is possible because |
Excellent, then i'll move this from draft to PR. |
joshanne
force-pushed
the
pr/move-chibios-hwdef-generation-to-explicit-call
branch
from
c870c0a
to
a63fafc
Compare
joshanne
commented
Sep 3, 2024
joshanne
force-pushed
the
pr/move-chibios-hwdef-generation-to-explicit-call
branch
from
e600168
to
0714abe
Compare
joshanne
force-pushed
the
pr/move-chibios-hwdef-generation-to-explicit-call
branch
from
0714abe
to
0a453bf
Compare
If is not provided at build time, then AP_SIGNED_FIRMWARE results in empty list. If is provided at build time, then AP_SIGNED_FIRMWARE results in .
joshanne
force-pushed
the
pr/move-chibios-hwdef-generation-to-explicit-call
branch
from
0a453bf
to
b002b6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change would explicitly call the
chibios_hwdef.ChibiOSHWDefrunfunction - instead of palming it off to asubprocess.callThis replaces the work from #27955 which builds upon #27988